From 1e47f74ef814a0599cbda4b5ac24e0662ca3060a Mon Sep 17 00:00:00 2001 From: Hector Sanjuan Date: Mon, 16 Dec 2019 15:07:03 +0100 Subject: [PATCH] Follow: simplify tracing/metrics [no] setup a bit --- cmd/ipfs-cluster-follow/commands.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cmd/ipfs-cluster-follow/commands.go b/cmd/ipfs-cluster-follow/commands.go index c3578a1a..e8ab3496 100644 --- a/cmd/ipfs-cluster-follow/commands.go +++ b/cmd/ipfs-cluster-follow/commands.go @@ -339,20 +339,17 @@ func runCmd(c *cli.Context) error { tracerCfg.Default() tracerCfg.EnableTracing = false cfgs.Tracing = &tracerCfg - cfgHelper.SetupTracing(false) tracer, err := observations.SetupTracing(&tracerCfg) if err != nil { return cli.Exit(errors.Wrap(err, "error setting up tracer"), 1) } + // This does nothing since we are not calling SetupMetrics anyways + // But stays just to be explicit. metricsCfg := observations.MetricsConfig{} metricsCfg.Default() metricsCfg.EnableStats = false cfgs.Metrics = &metricsCfg - err = observations.SetupMetrics(cfgs.Metrics) - if err != nil { - return cli.Exit(errors.Wrap(err, "error setting up metrics"), 1) - } cluster, err := ipfscluster.NewCluster( ctx,