cascade/ipfs-cluster
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #2004: Do not pre-resolve node_multiaddress

Browse Source 
I cannot remember the reason this was done this way. It seems stupid now.
Hopefully it was stupid.
This commit is contained in:
Hector Sanjuan 2024-01-08 21:53:40 +01:00
parent af89f73c2e
commit 51c0c8c23b
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ipfsconn/ipfshttp/ipfshttp.go
View File

@ -27,7 +27,6 @@ import (
logging "github.com/ipfs/go-log/v2"
rpc "github.com/libp2p/go-libp2p-gorpc"
peer "github.com/libp2p/go-libp2p/core/peer"
madns "github.com/multiformats/go-multiaddr-dns"
manet "github.com/multiformats/go-multiaddr/net"
"github.com/multiformats/go-multicodec"
multihash "github.com/multiformats/go-multihash"
@ -141,20 +140,7 @@ func NewConnector(cfg *Config) (*Connector, error) {
return nil, err
}
nodeMAddr := cfg.NodeAddr
// dns multiaddresses need to be resolved first
if madns.Matches(nodeMAddr) {
ctx, cancel := context.WithTimeout(context.Background(), DNSTimeout)
defer cancel()
resolvedAddrs, err := madns.Resolve(ctx, cfg.NodeAddr)
if err != nil {
logger.Error(err)
return nil, err
}
nodeMAddr = resolvedAddrs[0]
}
nodeNetwork, nodeAddr, err := manet.DialArgs(nodeMAddr)
nodeNetwork, nodeAddr, err := manet.DialArgs(cfg.NodeAddr)
if err != nil {
return nil, err
}