Additional fixes for security warnings from CodeQL

api/pinsvcapi/pinsvc/pinsvc.go

@@ -238,7 +238,7 @@ type ListOptions struct {
 	Status           Status
 	Before           time.Time
 	After            time.Time
-	Limit            int
+	Limit            uint64
 	Meta             map[string]string
 }
 
@@ -288,14 +288,11 @@ func (lo *ListOptions) FromQuery(q url.Values) error {
 	}
 
 	if v := q.Get("limit"); v != "" {
-		lim, err := strconv.ParseInt(v, 10, 64)
+		lim, err := strconv.ParseUint(v, 10, 64)
 		if err != nil {
 			return fmt.Errorf("error parsing 'limit' query param: %s: %w", v, err)
 		}
-		if lim < 0 {
-			return errors.New("'limit' cannot be negative")
-		}
-		lo.Limit = int(lim)
+		lo.Limit = lim
 	}
 
 	if meta := q.Get("meta"); meta != "" {

api/pinsvcapi/pinsvcapi.go

@@ -321,7 +321,7 @@ func (api *API) listPins(w http.ResponseWriter, r *http.Request) {
 		}
 
 		var err error
-		i := 0
+		i := uint64(0)
 		for stResult := range stCh {
 			if stResult.st.Status == pinsvc.StatusUndefined && stResult.err == nil {
 				// ignore things unpinning
@@ -360,7 +360,7 @@ func (api *API) listPins(w http.ResponseWriter, r *http.Request) {
 			)
 		}()
 
-		i := 0
+		i := uint64(0)
 		for gpi := range out {
 			st := globalPinInfoToSvcPinStatus(gpi.Cid.String(), gpi)
 			if st.Status == pinsvc.StatusUndefined {

api/util.go

@@ -21,7 +21,6 @@ func StringsToPeers(strs []string) []peer.ID {
 	for _, p := range strs {
 		pid, err := peer.Decode(p)
 		if err != nil {
-			logger.Debugf("'%s': %s", p, err)
 			continue
 		}
 		peers = append(peers, pid)