CRDT: TrustAll by default.

consensus/crdt/config.go

@@ -24,6 +24,7 @@ var (
 	DefaultDatastoreNamespace  = "/c" // from "/crdt"
 	DefaultRebroadcastInterval = time.Minute
 	DefaultTrustedPeers        = []peer.ID{}
+	DefaultTrustAll            = true
 )
 
 // Config is the configuration object for Consensus.
@@ -136,11 +137,16 @@ func (cfg *Config) ToJSON() ([]byte, error) {
 func (cfg *Config) toJSONConfig() *jsonConfig {
 	jcfg := &jsonConfig{
 		ClusterName:         cfg.ClusterName,
-		TrustedPeers:        api.PeersToStrings(cfg.TrustedPeers),
 		PeersetMetric:       "",
 		RebroadcastInterval: "",
 	}
 
+	if cfg.TrustAll {
+		jcfg.TrustedPeers = []string{"*"}
+	} else {
+		jcfg.TrustedPeers = api.PeersToStrings(cfg.TrustedPeers)
+	}
+
 	if cfg.PeersetMetric != DefaultPeersetMetric {
 		jcfg.PeersetMetric = cfg.PeersetMetric
 		// otherwise leave empty/hidden
@@ -165,7 +171,7 @@ func (cfg *Config) Default() error {
 	cfg.PeersetMetric = DefaultPeersetMetric
 	cfg.DatastoreNamespace = DefaultDatastoreNamespace
 	cfg.TrustedPeers = DefaultTrustedPeers
-	cfg.TrustAll = false
+	cfg.TrustAll = DefaultTrustAll
 	return nil
 }
 

consensus/crdt/config_test.go

@@ -18,8 +18,8 @@ func TestLoadJSON(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if cfg.TrustAll {
-		t.Error("expected TrustAll to be false")
+	if cfg.TrustAll != DefaultTrustAll {
+		t.Error("expected TrustAll to be the default")
 	}
 
 	cfg = &Config{}