cascade/ipfs-cluster
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client: do not cancel request context while reading the answer

Browse Source 
Apparently, cancelling the request context closes the response body
prematurely, before it's being fully read.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
This commit is contained in:
Hector Sanjuan 2017-12-07 18:47:35 +01:00
parent 34c815b0ee
commit 72928d5e3b
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/rest/client/request.go
View File

@ -1,7 +1,6 @@
package client
import (
"context"
"encoding/json"
"io"
"io/ioutil"
@ -20,9 +19,6 @@ func (c *Client) do(method, path string, body io.Reader, obj interface{}) *api.E
}
func (c *Client) doRequest(method, path string, body io.Reader) (*http.Response, error) {
ctx, cancel := context.WithTimeout(c.ctx, c.config.Timeout)
defer cancel()
urlpath := c.urlPrefix + "/" + strings.TrimPrefix(path, "/")
logger.Debugf("%s: %s", method, urlpath)
@ -38,7 +34,7 @@ func (c *Client) doRequest(method, path string, body io.Reader) (*http.Response,
r.SetBasicAuth(c.config.Username, c.config.Password)
}
return c.client.Do(r.WithContext(ctx))
return c.client.Do(r)
}
func (c *Client) handleResponse(resp *http.Response, obj interface{}) *api.Error {